Added equality/comparison overloads for Duration and TimeSpan #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| TimeSpan timeSpan = TimeSpan.FromHours(12); | ||
| Duration duration = Duration.FromHours(11); | ||
| Assert.IsTrue(timeSpan != duration, "timeSpan should equal to duraiton"); |
There was a problem hiding this comment.
A couple of typos on duraiton here.
|
Other than that, looks good. Let me know when fixed and I will merge it in. |
|
Should be fixed now. |
|
Thanks. Also seems github finally introduced email notifications on new commits in a PR :-) |
|
Nuget out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added equality/comparison overloads for Duration and TimeSpan. This makes it easier to work seamlessly with both types in the same code.